relref replace - k6 #1888
Open
relref replace - k6 #1888
+101
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbymilo
requested review from
codebien and
joanlopez
and removed request for
a team
| @@ -7,6 +7,6 @@ title: jslib/aws module blocking admonition | |||
| In some cases, using this library's operations might impact performance and skew your test results. | |||
| <br> | |||
| <br> | |||
| To ensure accurate results, consider executing these operations in the `setup` and `teardown` [lifecycle functions]({{< relref "../using-k6/test-lifecycle" >}}). These functions run before and after the test run and have no impact on the test results. | |||
| To ensure accurate results, consider executing these operations in the `setup` and `teardown` [lifecycle functions](../../using-k6/test-lifecycle/). These functions run before and after the test run and have no impact on the test results. | |||
There was a problem hiding this comment.
Suggested change
| To ensure accurate results, consider executing these operations in the `setup` and `teardown` [lifecycle functions](../../using-k6/test-lifecycle/). These functions run before and after the test run and have no impact on the test results. | |
| To ensure accurate results, consider executing these operations in the `setup` and `teardown` [lifecycle functions](htts://grafana.com/docs/k6/<K6_VERSION>/using-k6/test-lifecycle/). These functions run before and after the test run and have no impact on the test results. |
I tried to run this locally and I think the link isn't working. :( Maybe we just replace it with the full URL?
| @@ -7,6 +7,6 @@ title: k6/crypto module admonition | |||
| A module with a better and standard API exists. | |||
| <br> | |||
| <br> | |||
| The new [k6/experimental/webcrypto API]({{< relref "../javascript-api/k6-experimental/webcrypto" >}}) partially implements the [WebCryptoAPI](https://www.w3.org/TR/WebCryptoAPI/), supporting more features than [k6/crypto]({{< relref "../javascript-api/k6-crypto" >}}). | |||
| The new [k6/experimental/webcrypto API](../../javascript-api/k6-experimental/webcrypto/) partially implements the [WebCryptoAPI](https://www.w3.org/TR/WebCryptoAPI/), supporting more features than [k6/crypto](../../javascript-api/k6-crypto/). | |||
There was a problem hiding this comment.
Suggested change
| The new [k6/experimental/webcrypto API](../../javascript-api/k6-experimental/webcrypto/) partially implements the [WebCryptoAPI](https://www.w3.org/TR/WebCryptoAPI/), supporting more features than [k6/crypto](../../javascript-api/k6-crypto/). | |
| The new [k6/experimental/webcrypto API](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-experimental/webcrypto/) partially implements the [WebCryptoAPI](https://www.w3.org/TR/WebCryptoAPI/), supporting more features than [k6/crypto](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-crypto/). |
| @@ -7,7 +7,7 @@ title: Experimental module admonition | |||
| This is an experimental module. | |||
| <br> | |||
| <br> | |||
| While we intend to keep experimental modules as stable as possible, we may need to introduce breaking changes. This could happen at future k6 releases until the module becomes fully stable and graduates as a k6 core module. For more information, refer to the [extension graduation process]({{< relref "../extensions/explanations/extension-graduation" >}}). | |||
| While we intend to keep experimental modules as stable as possible, we may need to introduce breaking changes. This could happen at future k6 releases until the module becomes fully stable and graduates as a k6 core module. For more information, refer to the [extension graduation process](../../extensions/explanations/extension-graduation/). | |||
There was a problem hiding this comment.
Suggested change
| While we intend to keep experimental modules as stable as possible, we may need to introduce breaking changes. This could happen at future k6 releases until the module becomes fully stable and graduates as a k6 core module. For more information, refer to the [extension graduation process](../../extensions/explanations/extension-graduation/). | |
| While we intend to keep experimental modules as stable as possible, we may need to introduce breaking changes. This could happen at future k6 releases until the module becomes fully stable and graduates as a k6 core module. For more information, refer to the [extension graduation process](https://grafana.com/docs/k6/<K6_VERSION>/extensions/explanations/extension-graduation/). |
| @@ -7,7 +7,7 @@ title: k6/ws module admonition | |||
| A module with a better and standard API exists. | |||
| <br> | |||
| <br> | |||
| The new [k6/experimental/websockets API]({{< relref "../javascript-api/k6-experimental/websockets" >}}) partially implements the [WebSockets API living standard](https://websockets.spec.whatwg.org/). | |||
| The new [k6/experimental/websockets API](../../javascript-api/k6-experimental/websockets/) partially implements the [WebSockets API living standard](https://websockets.spec.whatwg.org/). | |||
There was a problem hiding this comment.
Suggested change
| The new [k6/experimental/websockets API](../../javascript-api/k6-experimental/websockets/) partially implements the [WebSockets API living standard](https://websockets.spec.whatwg.org/). | |
| The new [k6/experimental/websockets API](https://grafana.com/docs/k6/<K6_VERSION>/javascript-api/k6-experimental/websockets/) partially implements the [WebSockets API living standard](https://websockets.spec.whatwg.org/). |
|
@robbymilo thank you so much for opening this. 🙇 I left some comments there, could we replace the relative links with the full URLs? I think we ended up with some broken links because of it. |
|
Thanks for the catch @heitortsergent! https://github.com/grafana/website/pull/24498#issuecomment-2717032275 shows that the original commit did introduce some errors due to the shared files. I've fixed them and now https://github.com/grafana/website/pull/24498#issuecomment-2717083340 is showing no broken links. |
heitortsergent
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/grafana/website/issues/24017
Removes all relref shortcodes.
Repository: grafana/k6-docs
Website-Pull-Request: https://github.com/grafana/website/pull/24498