-
Notifications
You must be signed in to change notification settings - Fork 239
metrics: Use the correct term for types #2019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I should update the all the previous versions + next. I will do it asap tomorrow. |
0c60062
to
a10b6d8
Compare
As this is not relevant for the release, I set this back to a draft because it requires additional work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, despite of what's already being pointed out by Mihail! 👍🏻
@codebien do you want me to finish making the changes for this PR and merging it? 🙇 |
Hey @heitortsergent,
thanks for offering! If you have the time to finish making the changes and merge this PR, that would be great. Otherwise, I will find some time to do it before the end of the week.
|
💻 Deploy preview deleted. |
What?
In principle k6 has metric types and users can create custom metrics with them. But the two definitions are not strictly the same.
Checklist
npm start
command locally and verified that the changes look good.docs/sources/k6/next
folder of the documentation.docs/sources/k6/v{most_recent_release}
folder of the documentation.docs/sources/k6/next
folder of the documentation.Related PR(s)/Issue(s)