Skip to content

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Aug 6, 2025

What?

In principle k6 has metric types and users can create custom metrics with them. But the two definitions are not strictly the same.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/k6/next folder of the documentation.
  • I have reflected my changes in the docs/sources/k6/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).
  • I have made my changes in the docs/sources/k6/next folder of the documentation.

Related PR(s)/Issue(s)

@codebien codebien requested review from heitortsergent and a team as code owners August 6, 2025 10:32
@codebien codebien requested review from mstoykov and joanlopez and removed request for a team August 6, 2025 10:32
@CLAassistant
Copy link

CLAassistant commented Aug 6, 2025

CLA assistant check
All committers have signed the CLA.

@codebien
Copy link
Contributor Author

I should update the all the previous versions + next. I will do it asap tomorrow.

@codebien codebien changed the title Fix a typo on Rate page metrics: Use the correct term for types Aug 12, 2025
@codebien
Copy link
Contributor Author

As this is not relevant for the release, I set this back to a draft because it requires additional work.

@codebien codebien marked this pull request as draft August 12, 2025 13:58
Copy link
Contributor

@joanlopez joanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, despite of what's already being pointed out by Mihail! 👍🏻

@heitortsergent
Copy link
Collaborator

@codebien do you want me to finish making the changes for this PR and merging it? 🙇

@heitortsergent heitortsergent self-assigned this Sep 2, 2025
@heitortsergent heitortsergent added the Area: OSS Content Improvements or additions to community/oss documentation label Sep 2, 2025
@codebien
Copy link
Contributor Author

codebien commented Sep 2, 2025 via email

Copy link
Contributor

github-actions bot commented Sep 3, 2025

💻 Deploy preview deleted.

@heitortsergent heitortsergent marked this pull request as ready for review September 3, 2025 15:40
@heitortsergent heitortsergent merged commit b09c218 into main Sep 3, 2025
9 checks passed
@heitortsergent heitortsergent deleted the fix-metric-typo branch September 3, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OSS Content Improvements or additions to community/oss documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants