feat: add support for Chromium on all platforms #535
+81
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I installed Chromium with homebrew and got this error:
@going-confetti I've made some changes in the browser process to catch the exception and used a listener to show a toast in the frontend. I'll pick up #525 next so we can make the settings dialog more accessible.
Comment on lines
+99
to
+104
| const browserProc = launch({ | ||
| executablePath: path, | ||
| args: args, | ||
| onExit: sendBrowserClosedEvent, | ||
| }) | ||
| browserProc.nodeProcess.on('error', sendBrowserLaunchFailedEvent) |
There was a problem hiding this comment.
launch uses spawn under the hood, which handles errors asynchronously, so try/catch doesn't work here and we need to listen on error instead.
5 tasks
e-fisher
previously approved these changes
Mar 19, 2025
5 tasks
Would be interesting to understand why it fails since we are trying to autodetect it there as well 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the Linux PR #513 and makes Chromium the second default browser for all platforms.
How to Test
browser.tsto make sure Chromium is detected$PATHfor it to be detected. Once it's added, restart your terminal and relaunch the applicationnpm startChecklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)
Resolves #533