feat: Update splashscreen #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
going-confetti
commented
Mar 18, 2025
Comment on lines
-261
to
+264
| await createSplashWindow() | ||
| await initSettings() | ||
| appSettings = await getSettings() | ||
| nativeTheme.themeSource = appSettings.appearance.theme | ||
| await createSplashWindow() |
There was a problem hiding this comment.
If the OS settings don't match whatever is saved in the k6 Studio settings, there's a noticeable flash that occurs once the settings are loaded.
going-confetti
commented
Mar 18, 2025
going-confetti
commented
Mar 18, 2025
Comment on lines
+7
to
+12
| <stop offset="0.26" stop-color="#F35D29"> | ||
| <animate attributeName="stop-color" values="#F35D29; #FAAF13; #F35D29" dur="2s" repeatCount="indefinite" /> | ||
| </stop> | ||
| <stop offset="1" stop-color="#FAAF13"> | ||
| <animate attributeName="stop-color" values="#FAAF13; #F35D29; #FAAF13" dur="2s" repeatCount="indefinite" /> | ||
| </stop> |
There was a problem hiding this comment.
The gradient animation in the k6 logo. The values are identical in both files.
going-confetti
commented
Mar 19, 2025
Comment on lines
+148
to
+149
| width: 600, | ||
| height: 400, |
There was a problem hiding this comment.
The new size has the same aspect ratio as the default one for the main window. I don't feel strongly about that, but I think it looks better with less white space on the sides
going-confetti
commented
Mar 19, 2025
| opacity: 1; | ||
| } | ||
| 100% { | ||
| content: 'Almost there...'; |
There was a problem hiding this comment.
I chose the "boring" option for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to Test
Comment out
splashscreenWindow.close()inmain.tsScreenshots (if appropriate):
Screen.Recording.2025-03-19.at.12.27.50.mov
Screen.Recording.2025-03-19.at.12.28.44.mov