Skip to content

Add support to set the GC Stack the CLI should use by default #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed

Add support to set the GC Stack the CLI should use by default #4940

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
f2b14fd
Add stack ID and slug support to cloud login command
dgzlopes Jul 17, 2025
12ff28d
Implement default stack in interactive mode
dgzlopes Jul 17, 2025
2813fd8
Don't run the migration twice
dgzlopes Jul 17, 2025
671c401
Update examples, other flags and hide the ID from users
dgzlopes Jul 17, 2025
12fc907
Add support for retrieving default projectID based on stackID
dgzlopes Jul 17, 2025
ff92bc4
Add warning when default projectID is used
dgzlopes Jul 17, 2025
db0134a
Handle lack of stack info
dgzlopes Jul 18, 2025
6f23366
Add support for setting slug in the script
dgzlopes Jul 18, 2025
2f92dc5
Move shared logic to common
dgzlopes Jul 18, 2025
d048793
Improve response handling in GetDefaultProject (errcheck)
dgzlopes Jul 18, 2025
408f03b
Keep making linter happy
dgzlopes Jul 18, 2025
f0cd139
Don't use underscores
dgzlopes Jul 18, 2025
79806d7
Don't use logrus directly
dgzlopes Jul 18, 2025
dc427dd
Comment GetDefaultProject function
dgzlopes Jul 18, 2025
c619442
Remove nesting
dgzlopes Jul 18, 2025
44b495a
Remove breaking change
dgzlopes Jul 18, 2025
217e011
Make login code cleaner
dgzlopes Jul 18, 2025
35b4015
Make it work with stack tokens
dgzlopes Jul 18, 2025
3f6df55
Keep token input as a StringField
dgzlopes Jul 22, 2025
154b3ed
Change warning text
dgzlopes Jul 22, 2025
e19b61f
Only display login message if token is valid
dgzlopes Jul 22, 2025
547f356
Improve error handling in getDefaultStack
dgzlopes Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/cmd/cloud.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,11 @@ func (c *cmdCloud) run(cmd *cobra.Command, args []string) error {
logger, cloudConfig.Token.String, cloudConfig.Host.String, build.Version, cloudConfig.Timeout.TimeDuration())

if cloudConfig.ProjectID.Int64 == 0 {
if cloudConfig.StackID.Int64 == 0 {
logger.Error("please specify a projectID in your test or use `k6 cloud login` to set up a default stack")
return fmt.Errorf("no projectID specified and no default stack set")
}

projectID, _, err := client.GetDefaultProject(cloudConfig.StackID.Int64)
if err != nil {
return fmt.Errorf("can't get default projectID for stack %d (%s): %w", cloudConfig.StackID.Int64, cloudConfig.StackSlug.String, err)
Expand Down
5 changes: 5 additions & 0 deletions internal/cmd/outputs_cloud.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,11 @@ func createCloudTest(gs *state.GlobalState, test *loadedAndConfiguredTest) error
logger, conf.Token.String, conf.Host.String, build.Version, conf.Timeout.TimeDuration())

if testRun.ProjectID == 0 {
if conf.StackID.Int64 == 0 {
gs.Logger.Error("please specify a projectID in your test or use `k6 cloud login` to set up a default stack")
return fmt.Errorf("no projectID specified and no default stack set")
}

projectID, _, err := apiClient.GetDefaultProject(conf.StackID.Int64)
if err != nil {
return fmt.Errorf("can't get default projectID for stack %d (%s): %w", conf.StackID.Int64, conf.StackSlug.String, err)
Expand Down
Loading