use source readers #76
Conversation
pablochacin
force-pushed
the
use-source-reader
branch
from
6b78dac to
2bc91c3
Compare
Signed-off-by: Pablo Chacin <[email protected]>
pablochacin
force-pushed
the
use-source-reader
branch
from
2bc91c3 to
793cbb5
Compare
| @@ -67,7 +67,7 @@ func Test_scriptAnalyzer(t *testing.T) { | |||
| fn := scriptAnalyzer(src) | |||
| deps, err := fn() | |||
|
|
|||
| require.NoError(t, err) | |||
| require.Error(t, err) | |||
There was a problem hiding this comment.
Isn't that right, that now we expect error? 😅
There was a problem hiding this comment.
Yeah, I documented in the PR as a breaking change
If the script source is given a name but not content, the name is used as the script's file and its content is tried to be read. Before this was not the case because it was assumed the content was already read always
There was a problem hiding this comment.
I see, yes makes totally sense!
| @@ -163,27 +144,38 @@ func loadEnv(opts *Options) { | |||
| opts.Env.Contents = []byte(value) | |||
| } | |||
|
|
|||
| func findManifest(filename string) ([]byte, string, bool, error) { | |||
| func (opts *Options) findManifest() error { | |||
| path, found, err := findManifest(opts.Script.Name) | |||
There was a problem hiding this comment.
I know that old code has it too, but why do we search manifest, by using opts.Script.Name ? 🤔
I think it could confuse a bit of future contributors and if that's, that's the right way, it's good to have a comment here
options.go
Outdated
| @@ -163,27 +144,38 @@ func loadEnv(opts *Options) { | |||
| opts.Env.Contents = []byte(value) | |||
| } | |||
|
|
|||
| func findManifest(filename string) ([]byte, string, bool, error) { | |||
| func (opts *Options) findManifest() error { | |||
There was a problem hiding this comment.
I feel that it's worth giving the name that represents that state is changes, like initializeManifest or configureManifest
Signed-off-by: Pablo Chacin <[email protected]>
|
LGTM! 🚀 |
Use the source's reader when analyzing dependencies.
The source's reader comes from the content or from reading the source's file (this applies to archive, script, and manifest). For the Environment source, it is assumed that the content is always present.
Breaking changes: