Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: canary only worked when gateway enabled #16758

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jacobcrawford
Copy link

@jacobcrawford jacobcrawford commented Mar 14, 2025

What this PR does / why we need it:
The Loki Canary only worked when the gateway was enabled. We should support setting the Loki endpoint through values so it does not have as hard dependency to the gateway.

Which issue(s) this PR fixes:
Fixes #14233
Fixes #11208

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Mar 14, 2025
@jacobcrawford jacobcrawford force-pushed the bugfix-canary-only-worked-when-gateway-enabled branch from fca1d8e to 7c00dd0 Compare March 14, 2025 10:44
@jacobcrawford jacobcrawford changed the title canary only worked when gateway enabled fix: canary only worked when gateway enabled Mar 14, 2025
@jacobcrawford jacobcrawford marked this pull request as ready for review March 14, 2025 10:46
@jacobcrawford jacobcrawford requested a review from a team as a code owner March 14, 2025 10:46
@@ -6690,6 +6690,15 @@ null
<td><pre lang="json">
"pod"
</pre>
</td>
Copy link
Contributor

@JStickler JStickler Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that /helm/reference.md is a generated file. You need to modify the template, not the generated file.

This note is at line 11 in the file. "Autogenerated. Modify ../production/helm/loki/reference.md.gotmpl "

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are the product of running make helm-docs in the root of the project:
image

I followed the contributing guide at: ./production/helm/loki/README.md is that not correct? 😃

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the changes to reference.md came from running make helm-docs? If that's the case, you're fine. But if you manually edited the file, the changes will be overwritten the next time the file is generated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct! The changes are only made from running make helm-docs and i have not made any manual changes to the docs 😄

@jacobcrawford jacobcrawford requested a review from JStickler March 17, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canary points to gateway when gateway is disabled. Loki Canary seems broken when gateway is disabled
3 participants