-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: canary only worked when gateway enabled #16758
base: main
Are you sure you want to change the base?
fix: canary only worked when gateway enabled #16758
Conversation
fca1d8e
to
7c00dd0
Compare
@@ -6690,6 +6690,15 @@ null | |||
<td><pre lang="json"> | |||
"pod" | |||
</pre> | |||
</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that /helm/reference.md
is a generated file. You need to modify the template, not the generated file.
This note is at line 11 in the file. "Autogenerated. Modify ../production/helm/loki/reference.md.gotmpl "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the changes to reference.md
came from running make helm-docs
? If that's the case, you're fine. But if you manually edited the file, the changes will be overwritten the next time the file is generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct! The changes are only made from running make helm-docs
and i have not made any manual changes to the docs 😄
What this PR does / why we need it:
The Loki Canary only worked when the gateway was enabled. We should support setting the Loki endpoint through values so it does not have as hard dependency to the gateway.
Which issue(s) this PR fixes:
Fixes #14233
Fixes #11208
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR