-
Notifications
You must be signed in to change notification settings - Fork 3.9k
chore(metastore): add column reader for pointers section #19992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a31b118 to
159273e
Compare
ivkalita
commented
Nov 28, 2025
ivkalita
commented
Nov 28, 2025
ivkalita
commented
Nov 28, 2025
159273e to
8190ded
Compare
benclive
reviewed
Nov 28, 2025
Use columnar reader to read the stream pointers
8190ded to
2bbf368
Compare
benclive
approved these changes
Nov 28, 2025
Contributor
benclive
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM, thanks!
I left one reply below about re-using the predicate, but I don't think it's a big deal so I'm happy for you to decide. Approving!
6 tasks
ivkalita
added a commit
that referenced
this pull request
Dec 1, 2025
This PR is a continuation of #19992. I use `pointers.Reader` to refine the sections that match bloom filters. I also fix minor issues that I introduced in the previous PR: - convert the columns only once per column (instead of doing it for every row) - ignore the sections that are of a wrong "type"
7 tasks
ivkalita
added a commit
that referenced
this pull request
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding columnar reader for (log)pointers section.
New reader is slower than existing RowReader due to double-translation of the data (columns->rows->rows vs columns->rows->columns->rows). The idea though is to get rid of the double-translation in the future.
Read section benchmarks
RowReader vs Reader comparison benchmarks
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR