chore(dataobj): Use common base config for indexobj and logsobj builders #20037
+166
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
💻 Deploy preview deleted (chore(dataobj): Use common base config for indexobj and logsobj builders). |
chaudum
force-pushed
the
chaudum/builder-base-config
branch
2 times, most recently
from
6db5378 to
c878399
Compare
ashwanthgoli
approved these changes
Nov 28, 2025
docs/sources/shared/configuration.md
Outdated
|
|
||
| # The maximum number of stripes to merge into a section at once. Must be | ||
| # greater than 1. | ||
| # The maximum number of log section stripes to merge into a section at once. |
Contributor
There was a problem hiding this comment.
Suggested change
| # The maximum number of log section stripes to merge into a section at once. | |
| # The maximum number of dataobj section stripes to merge into a section at once. |
Use the same config struct for both the indexobj builder and the logsobj builder, since they are configured identically, only with different default values.
chaudum
force-pushed
the
chaudum/builder-base-config
branch
from
c878399 to
92b6fe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the same config struct for both the indexobj builder and the logsobj builder, since they are configured identically, only with different default values.