Limit the data returned in list operations #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running list operations against large instances even the default limits were causing things like Cursor or Claude Desktop to bail as the conversation was too large. Using summary types for these calls instead allow them to return with reasonable limits.
sd2k
reviewed
Feb 24, 2025
Comment on lines
+9
to
+27
| async def list_datasources() -> List[Datasource]: | ||
| """ | ||
| List datasources in the Grafana instance. | ||
| """ | ||
| return await grafana_client.list_datasources() | ||
| datasources = await grafana_client.list_datasources() | ||
| resp = [] | ||
| # Only push a subset of fields to save on space. | ||
| for ds in datasources: | ||
| resp.append( | ||
| { | ||
| "id": ds.id, | ||
| "uid": ds.uid, | ||
| "name": ds.name, | ||
| "type": ds.type, | ||
| "isDefault": ds.is_default, | ||
| } | ||
| ) | ||
|
|
||
| return resp |
There was a problem hiding this comment.
I think this type annotation is incorrect since we're returning dicts not datasource objects? Probably doesn't matter for now but mypy will probably complain if/when we add it.
Perhaps we could add a more minimal Datasource type instead though, since the model might be expecting to see all the fields if it's passed the schema of the Datasource type.
There was a problem hiding this comment.
Yep, that is on the list of things to fix before I mark this as ready to review.
|
Supserseded by #30. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running list operations against large instances even the default limits were causing things like Cursor or Claude Desktop to bail as the conversation was too large. Using summary types for these calls instead allow them to return with reasonable limits.