Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datasources #35

Merged
merged 3 commits into from
Mar 13, 2025
Merged

Add datasources #35

merged 3 commits into from
Mar 13, 2025

Conversation

ioanarm
Copy link
Contributor

@ioanarm ioanarm commented Mar 12, 2025

Adds demo datasources

@ioanarm ioanarm requested a review from a team as a code owner March 12, 2025 12:34
@ioanarm ioanarm force-pushed the dc-add-datasources branch from c20e40f to 6bdac61 Compare March 12, 2025 12:41
@ioanarm ioanarm force-pushed the dc-add-datasources branch from 6bdac61 to 0dbe2da Compare March 12, 2025 13:13
@ioanarm ioanarm changed the title Add datasources including dev Add datasources Mar 12, 2025
Copy link
Contributor

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a test is only expecting one datasource. Maybe just have it look for the existence of the first datasource but not care that there is exactly one?

@ioanarm ioanarm enabled auto-merge March 13, 2025 08:20
@ioanarm ioanarm merged commit 3619ce8 into main Mar 13, 2025
3 checks passed
@ioanarm ioanarm deleted the dc-add-datasources branch March 13, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants