Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distributor: add logs to flaky TestDistributor_Push_ShouldSupportWriteBothToIngestersAndPartitions #9323

Merged
merged 2 commits into from
Sep 20, 2024
Merged

distributor: add logs to flaky TestDistributor_Push_ShouldSupportWriteBothToIngestersAndPartitions #9323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36acd4c
distributor: add logs to flaky TestDistributor_Push_ShouldSupportWrit…
dimitarvdimitrov Sep 18, 2024
06a6330
More verbose
dimitarvdimitrov Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pkg/distributor/distributor_ingest_storage_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
"github.com/prometheus/prometheus/model/labels"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/twmb/franz-go/pkg/kadm"
"github.com/twmb/franz-go/pkg/kerr"
"github.com/twmb/franz-go/pkg/kgo"
"github.com/twmb/franz-go/pkg/kmsg"
Expand Down Expand Up @@ -452,7 +453,15 @@ func TestDistributor_Push_ShouldSupportWriteBothToIngestersAndPartitions(t *test

// Ensure series has been correctly sharded to partitions.
actualSeriesByPartition := readAllMetricNamesByPartitionFromKafka(t, kafkaCluster.ListenAddrs(), testConfig.ingestStoragePartitions, time.Second)
assert.Equal(t, testData.expectedMetricsByPartition, actualSeriesByPartition)
if !assert.Equal(t, testData.expectedMetricsByPartition, actualSeriesByPartition, "please report this failure in https://github.com/grafana/mimir/issues/9299") {
// This test is sometimes flaky. Add a log line to help debug it.
// Inspect the offsets of partitions in Kafka. There may be records, but we couldn't fetch them in the 1s timeout above.
kafkaClient, err := kgo.NewClient(kgo.SeedBrokers(kafkaCluster.ListenAddrs()...))
assert.NoError(t, err)
offsets, err := kadm.NewClient(kafkaClient).ListEndOffsets(context.Background(), kafkaTopic)
assert.NoError(t, err)
t.Logf("Kafka topic %s end offsets: %#v", kafkaTopic, offsets)
}

// Ensure series have been correctly sharded to ingesters.
for _, ingester := range ingesters {
Expand Down
Loading