-
Notifications
You must be signed in to change notification settings - Fork 7
feat: support react image in e2e matrix #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Since you are at it - bump the version please plugin-actions/e2e-version/action.yml Line 40 in 15a693d
|
e2e-version/get-react-image-tag.js
Outdated
| */ | ||
| module.exports = async ({ core }) => { | ||
| try { | ||
| console.log('Getting latest Grafana React tag from DockerHub...'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only skimmed the code but the react-19 tag doesn't change between pushes. See this temp change in grafana/grafana react PR.
jackw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! 🚀
Add support for e2e testing grafana plugins using a Grafana image built with React 19. The action now automatically includes the
dev-preview-react19image for Grafana org repositories by default, while external repositories skip it by default. Both can be overridden using the newskip-grafana-react-imageinput.Tested with internal repo: grafana/grafana-test-datasource#31
Tested with external repo: sunker/test-panel#3
Fixes #191