Add support for custom activity type (including variables) #23
Conversation
There was a problem hiding this comment.
Do you think fits better for this feature?
There's an example of usage: https://developers.grafana.com/ui/latest/index.html?path=/story/forms-select--multi-select
| return allActivities; | ||
| } else if (activityType === 'Custom' && customActivityType) { | ||
| // Handle template variables if any | ||
| if (customActivityType.indexOf('$') != -1) { |
There was a problem hiding this comment.
You don't need to check value for variables, getTemplateSrv().replace() already do this, so this can be omitted.
| @@ -34,6 +34,7 @@ const stravaActivityTypeOptions: Array<SelectableValue<StravaActivityType>> = [ | |||
| { value: 'Run', label: 'Run' }, | |||
| { value: 'Ride', label: 'Ride' }, | |||
| { value: 'Other', label: 'Other' }, | |||
| { value: 'Custom', label: 'Custom' }, | |||
There was a problem hiding this comment.
Isn't better to convert activity selector to support multi-value selection and add variables to the list?
There was a problem hiding this comment.
How would you know which variable to put in the list?
There was a problem hiding this comment.
Usually, it's just a list of created variables from templateSrv, but it might be bad from UX perspective.
|
|
Add a
Customoption in the activity type that shows an input where the user can type a coma-separated list of activity types or a variable name.