chore: integration: add tests for custom phases #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I initially assumed that we were converting from `http_req_XXX` to
`probe_http_duration_seconds{phase="XXX"}`, but this is not entirely
true: The naming of the phases is actually different.
This test ensures that the current names we use for those phases exist
in the output.
nadiamoe
commented
Feb 14, 2025
| { | ||
| name: "HTTP duration seconds has custom 'resolve' phase", |
There was a problem hiding this comment.
Oh blissful ignorance, all phases are actually custom.
d0ugal
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow-up to #44
I initially assumed that we were converting from
http_req_XXXtoprobe_http_duration_seconds{phase="XXX"}, but this is not entirely true: The naming of the phases is actually different.This test ensures that the current names we use for those phases exist in the output.