Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run integration tests against a local server, other improvements #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nadiamoe
Copy link
Member

@nadiamoe nadiamoe commented Mar 3, 2025

Testing against test-api.k6.io introduces reliability problems and may make the test flaky if the service is not responsive. Additionally, this includes some minor changes like logging the k6 output.

This one is actually an RFC as well: I'm curious on your opinions about this change, mainly whether you see the additional complexity worth it, or if you'd rather point to a more reliable online service.

@nadiamoe nadiamoe requested a review from a team as a code owner March 3, 2025 13:49
@nadiamoe nadiamoe requested review from d0ugal and The-9880 March 3, 2025 13:49
Testing against test-api.k6.io introduces reliability problems and may
make the test flaky if the service is not responsive.
Copy link
Contributor

@d0ugal d0ugal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this and think the extra complexity is worth it (and not that much extra). In some ways it is simpler to reason about and debug if something fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants