Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build a second binary with the Grafana secrets manager client extension #75

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

d0ugal
Copy link
Contributor

@d0ugal d0ugal commented Mar 4, 2025

This is a temporary workaround to allow us to build a unstable k6 which will only be used when secrets are present for the script.

In the future this should be removed and it should be included in the stable release.

This depends on grafana/gsm-api-go-client#1

This is a temporary workaround to allow us to build a unstable k6 which
will only be used when secrets are present for the script.

In the future this should be removed and it should be included in the
stable release.
@d0ugal d0ugal requested a review from a team as a code owner March 4, 2025 12:01
@d0ugal d0ugal requested review from mem and ka3de March 4, 2025 12:01
Copy link
Member

@nadiamoe nadiamoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I'd suggest adding a TODO comment somewhere so we don't forget this step is temporary, if you think it can be useful.

@d0ugal d0ugal enabled auto-merge (squash) March 7, 2025 15:00
@d0ugal d0ugal merged commit 31f4734 into main Mar 7, 2025
7 checks passed
@d0ugal d0ugal deleted the gsm-binary branch March 7, 2025 15:11
@sm-release-app sm-release-app bot mentioned this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants