Skip to content

fixing new york times content extraction failure #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fixing new york times content extraction failure #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50981db
fixing new york times content extraction failure
robmcdan Mar 14, 2015
d3ce67b
fixing index error in title_words for case where title is single char…
Dec 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion goose/extractors/content.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,11 @@


KNOWN_ARTICLE_CONTENT_TAGS = [
{'tag': 'article'},
{'attr': 'itemprop', 'value': 'articleBody'},
{'attr': 'class', 'value': 'post-content'},
{'tag': 'article'},
{'attr': 'class', 'value': "story-body-text"},
{'attr': 'class', 'value': "story-content"},
]


Expand Down
2 changes: 1 addition & 1 deletion goose/extractors/title.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def clean_title(self, title):

# check if last letter is in TITLE_SPLITTERS
# if so remove it
if title_words[-1] in TITLE_SPLITTERS:
if len(title_words) != 0 and title_words[-1] in TITLE_SPLITTERS:
title_words.pop(-1)

# rebuild the title
Expand Down
2 changes: 1 addition & 1 deletion goose/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@
limitations under the License.
"""

version_info = (1, 0, 25)
version_info = (1, 0, 26)
__version__ = ".".join(map(str, version_info))
Empty file added tests/data/extractors/content/test_newyorktimes.html
View file
Open in desktop
Empty file.
Empty file added tests/data/extractors/content/test_newyorktimes.json
View file
Open in desktop
Empty file.