Custom filter name via connectionFilterName#200
Open
pilsy wants to merge 7 commits intographile-contrib:masterfrom
Open
Custom filter name via connectionFilterName#200pilsy wants to merge 7 commits intographile-contrib:masterfrom
pilsy wants to merge 7 commits intographile-contrib:masterfrom
Conversation
Member
|
This need is better served by a small inflection plugin: import { makeAddInflectorsPlugin } from "graphile-utils";
export const FilterToWherePlugin = makeAddInflectorsPlugin(() => ({
filterType(typeName: string) {
return `${typeName}Where`;
},
filterFieldType(typeName: string) {
return `${typeName}Where`;
},
filterFieldListType(typeName: string) {
return `${typeName}ListWhere`;
},
filterArgumentName() {
return "where";
}
});The only change needed for this would be adding the new const filterArgumentName = inflection.filterArgumentName();and using that variable in the place of and here: postgraphile-plugin-connection-filter/src/PgConnectionArgFilterPlugin.ts Lines 107 to 109 in fcd5e92 Many of the changes made in this PR are undesirable; for example changing the smart tag from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where i work we wanted the ability to name the filter "where", so while we migrate from Hasura our queries will not change -- this PR adds this feature via connectionFilterName option