Fix XSS in some dashboards queries #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -111,6 +122,6 @@ | |||
| except InputParameterError as e: | |||
| msgStr = str(e) | |||
| log.warning('%s', msgStr) | |||
| return HttpResponseBadRequest(escape(msgStr)) | |||
| return HttpResponseBadRequest(htmlEscape(msgStr)) | |||
Check warning
Code scanning / CodeQL
Information exposure through an exception
msaf1980
force-pushed
the
fix_xss
branch
2 times, most recently
from
10e0e4f
to
b8c492f
Compare
msaf1980
commented
Oct 28, 2022
|
|
||
|
|
||
| def is_unclean_str(s): | ||
| for symbol in '&<>~!@#$%^*()`': |
There was a problem hiding this comment.
Minimal set of unsafe symbols is &<>. May be other symbols are accepted ?
There was a problem hiding this comment.
Let's stick to wide set for now, we'll fix later, if needed
This was referenced Nov 6, 2022
|
It would be nice to have a release incorporating this as it has now been indicated in 3 different CVEs: CVE-2022-4730, CVE-2022-4729 & CVE-2022-4728. |
|
Agreed, will do release soon |
deniszh
pushed a commit
to deniszh/graphite-web
that referenced
this pull request
Feb 19, 2023
* prevent xss on time range text fields * prevent xss on dashbord queries (cherry picked from commit 2f178f4) # Conflicts: # webapp/graphite/errors.py # webapp/tests/base.py
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
deniszh
added a commit
that referenced
this pull request
Feb 19, 2023
[1.1.x] Fix XSS in some dashboards queries (#2785)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes XSS in some dashboards queries:
issue #2744
issue #2745
Also fix:
issue #2746