Stop subgraphs passing max endBlock #5583
Merged
+72
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I think it'd be a bit more cleaner if we just set the exisiting |
|
@shuaibbapputty bump 😄 |
incrypto32
requested changes
Nov 12, 2024
| @@ -419,6 +426,7 @@ impl<S: SubgraphStore> SubgraphInstanceManager<S> { | |||
| start_blocks, | |||
| end_blocks, | |||
| stop_block, | |||
| max_end_block, | |||
There was a problem hiding this comment.
We already have a stop_block, why not set it instead of a separate max_end_block?
| @@ -331,6 +331,13 @@ impl<S: SubgraphStore> SubgraphInstanceManager<S> { | |||
| }) | |||
| .collect(); | |||
|
|
|||
| let max_end_block: Option<BlockNumber> = if manifest.data_sources.len() == end_blocks.len() | |||
There was a problem hiding this comment.
A subgraph can also have offchain data sources, so we cant just compare it like this since offchain datasources dont have an end block
|
Sorry for the delay @alex-pakalniskis As per my discussion with @incrypto32 on discord, I will address the review changes and update the PR asap. Thankyou! |
shuaibbapputty
force-pushed
the
shuaib/handle-max-endblock
branch
from
289343c
to
9458fc5
Compare
incrypto32
approved these changes
Nov 14, 2024
Co-authored-by: Krishnanand V P <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5535.
Previously, subgraphs continued scanning even when all the data sources had passed the end block.
This update finds the maximum end block across the data sources and stops the subgraph from scanning once the
max_end_blockis reached.