Implement a File Link Resolver #5981
Open
+453
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
force-pushed
the
krishna/refactor-main
branch
from
c8b8169 to
15fe3c3
Compare
incrypto32
force-pushed
the
krishna/file-link-resolver
branch
from
3ef16d5 to
23e91f1
Compare
lutter
approved these changes
May 7, 2025
|
|
||
| async fn json_stream(&self, _logger: &Logger, _link: &Link) -> Result<JsonValueStream, Error> { | ||
| Err(anyhow!("json_stream is not implemented for FileLinkResolver").into()) | ||
| } |
There was a problem hiding this comment.
Making these always return errors is sorta ugly. It would be nicer to have a trait FileResolver that doesn't have these two and a trait LinkResolver that does and change the code to use the right one. That's going to be a bigger change, so fine to do it in a separate PR, but we shouldn't let this linger for too long.
The danger with leaving this too long is that the code becomes brittle since now every user of LinkResolver needs to make sure it gets the right kind as that's not guaranteed by the type alone anymore
lutter
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a file system based link resolver aimed to replace IpfsLinkResolver for local development, this is in preparation for #5977