Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation for event handlers #1545

Merged
merged 5 commits into from
Dec 13, 2023
Merged

fix: validation for event handlers #1545

merged 5 commits into from
Dec 13, 2023

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Dec 13, 2023

Debugging an issue related to call handlers reported by @marcusrein and realized the changes I made last week are not needed because we already have a way to validate the WASM see: #1258

Copy link

cloudflare-workers-and-pages bot commented Dec 13, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cbd5345
Status: ✅  Deploy successful!
Preview URL: https://cfb7eca1.graph-tooling.pages.dev
Branch Preview URL: https://saihaj-fixing.graph-tooling.pages.dev

View logs

Copy link

changeset-bot bot commented Dec 13, 2023

🦋 Changeset detected

Latest commit: cbd5345

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphprotocol/graph-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@saihaj saihaj changed the title saihaj/fixing fix: validation for event handlers Dec 13, 2023
Copy link
Contributor

github-actions bot commented Dec 13, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphprotocol/graph-cli 0.64.0-alpha-20231213212340-cbd5345 npm ↗︎ unpkg ↗︎

@KholdStare
Copy link

Was about to file a bug report because graph build was crashing if a data source or template didn't have eventHandlers.

Just to double check - this will run the WASM validation during graph build?

@saihaj
Copy link
Member Author

saihaj commented Dec 13, 2023

Was about to file a bug report because graph build was crashing if a data source or template didn't have eventHandlers.

Just to double check - this will run the WASM validation during graph build?

yep we are always running the complie for WASM in build so it just makes sense to enable validation here

@saihaj saihaj merged commit 1cfc8ce into main Dec 13, 2023
11 checks passed
@saihaj saihaj deleted the saihaj/fixing branch December 13, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants