cli: Skip validations for aggregations #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9ea4027 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lutter
force-pushed
the
lutter/agg-minimal
branch
from
b850152 to
0ec6de6
Compare
Deploying with
|
| Latest commit: |
9ea4027
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://27921ab8.graph-tooling.pages.dev |
| Branch Preview URL: | https://lutter-agg-minimal.graph-tooling.pages.dev |
|
Fixed linting error and rebased to latest |
lutter
force-pushed
the
lutter/agg-minimal
branch
from
0ec6de6 to
a16e444
Compare
|
Can you please run also can revert the prettier auto-save change back to true cause I did fix it on main |
lutter
force-pushed
the
lutter/agg-minimal
branch
from
a16e444 to
9053c5d
Compare
This is a placeholder that simply allows `@aggregation` annotation. The real change should come from using `graph-node`'s validation functionality.
lutter
force-pushed
the
lutter/agg-minimal
branch
from
9053c5d to
9ea4027
Compare
|
Thanks for the review, I just fixed the PR up accordingly |
saihaj
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a placeholder that simply allows
@aggregationannotation. The real change should come from usinggraph-node's validation functionality.