Skip to content

fix: fix log namespace #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PaulRBerg
Copy link

I'm getting these type errors when running tsc --noEmit on a code base that uses @graphprotocol/graph-ts. This is even if I extend from your @graphprotocol/graph-ts/types/tsconfig.base.json file — using TypeScript 5.5.2

bun run tsc --noEmit --project ./the-graph/tsconfig.json
node_modules/@graphprotocol/graph-ts/index.ts:103:9 - error TS2339: Property 'log' does not exist on type 'typeof log'.

103     log.log(Level.CRITICAL, format(msg, args));
            ~~~

node_modules/@graphprotocol/graph-ts/index.ts:113:9 - error TS2339: Property 'log' does not exist on type 'typeof log'.

113     log.log(Level.ERROR, format(msg, args));
            ~~~

node_modules/@graphprotocol/graph-ts/index.ts:122:9 - error TS2339: Property 'log' does not exist on type 'typeof log'.

122     log.log(Level.WARNING, format(msg, args));
            ~~~

node_modules/@graphprotocol/graph-ts/index.ts:131:9 - error TS2339: Property 'log' does not exist on type 'typeof log'.

131     log.log(Level.INFO, format(msg, args));
            ~~~

node_modules/@graphprotocol/graph-ts/index.ts:140:9 - error TS2339: Property 'log' does not exist on type 'typeof log'.

140     log.log(Level.DEBUG, format(msg, args));

This PR fixes the double namespace.

P.S. I assume that the original version works with AssemblyScript, but it's a bad UI/UX to have the AssemblyScript code work but not the TypeScript compilation.

Copy link

changeset-bot bot commented May 3, 2025

⚠️ No Changeset found

Latest commit: c6b038b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant