Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use 65 bytes signature #124

Merged
merged 2 commits into from
Feb 27, 2024
Merged

fix: use 65 bytes signature #124

merged 2 commits into from
Feb 27, 2024

Conversation

gusinacio
Copy link
Member

remove open-fastrlp dependency, using bytes directly

@gusinacio
fix: use 65 bytes signature
b206e0b 
remove open-fastrlp dependency, using bytes directly
@gusinacio gusinacio requested a review from aasseman February 26, 2024 17:38
@gusinacio gusinacio self-assigned this Feb 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8069909178

Details

  • 0 of 7 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 64.933%
Files with Coverage Reduction New Missed Lines %
common/src/tap_manager.rs 1 88.57%
Totals Coverage Status
Change from base Build 8054436426: -0.04%
Covered Lines: 2846
Relevant Lines: 4383
💛 - Coveralls

@gusinacio
Copy link
Member Author

We'll use rlp inside indexer-agent

@gusinacio gusinacio closed this Feb 26, 2024
@gusinacio gusinacio reopened this Feb 27, 2024
aasseman
aasseman previously approved these changes Feb 27, 2024
View reviewed changes
@aasseman aasseman merged commit 04960d6 into main Feb 27, 2024
8 checks passed
@aasseman aasseman deleted the gusinacio/use-65-bytes-signature branch February 27, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasseman aasseman aasseman approved these changes

Assignees

@gusinacio gusinacio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gusinacio @aasseman