Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: capitalize scalar receipt header" #129

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

gusinacio
Copy link
Member

@gusinacio gusinacio commented Feb 29, 2024

Reverts #126

As per HeaderName::from_static documentation https://docs.rs/http/latest/http/header/struct.HeaderName.html#method.from_static. This panics if it's not lowercase and gets into a poisoned state because of lazy_static! use

@gusinacio gusinacio requested a review from hopeyen February 29, 2024 15:22
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8098386871

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 64.91%

Files with Coverage Reduction New Missed Lines %
tap-agent/src/tap/sender_accounts_manager.rs 2 58.46%
Totals Coverage Status
Change from base Build 8097174113: -0.05%
Covered Lines: 2845
Relevant Lines: 4383

💛 - Coveralls

@aasseman aasseman merged commit e046a97 into main Feb 29, 2024
8 checks passed
@aasseman aasseman deleted the revert-126-hope/receipt-header branch February 29, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants