Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SubgraphServiceError to return JSON-formatted error responses #652

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

neithanmo
Copy link
Collaborator

Updates the SubgraphServiceError implementation to return proper JSON-formatted responses, consistent with IndexerServiceError. This fixes JSON parsing errors in GraphQL clients when handling error cases, for example introspection queries

@neithanmo neithanmo force-pushed the fix/subgraph_service_error branch from 1e14ad0 to 54571c2 Compare March 13, 2025 19:42
@coveralls
Copy link

coveralls commented Mar 13, 2025

Pull Request Test Coverage Report for Build 13846533883

Details

  • 11 of 14 (78.57%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 75.771%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/service/src/error.rs 11 14 78.57%
Files with Coverage Reduction New Missed Lines %
crates/service/src/error.rs 1 60.0%
Totals Coverage Status
Change from base Build 13845873805: -0.008%
Covered Lines: 8325
Relevant Lines: 10987

💛 - Coveralls

@neithanmo neithanmo force-pushed the fix/subgraph_service_error branch from 54571c2 to 88967fa Compare March 13, 2025 23:25
@neithanmo neithanmo merged commit 228e701 into main Mar 14, 2025
10 checks passed
@neithanmo neithanmo deleted the fix/subgraph_service_error branch March 14, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants