feat: log proposal rejection reasons on the indexer side#968
Closed
MoonBoi9001 wants to merge 2 commits intomain-dipsfrom
Closed
feat: log proposal rejection reasons on the indexer side#968MoonBoi9001 wants to merge 2 commits intomain-dipsfrom
MoonBoi9001 wants to merge 2 commits intomain-dipsfrom
Conversation
MoonBoi9001
force-pushed
the
feat/dips-rejection-logging
branch
from
02746b3 to
63c0c2a
Compare
When an RCA proposal is rejected, log the rejection reason, error, and deployment ID (when decodable) at INFO level. Previously the rejection was returned via the gRPC response with no server-side log at INFO, making debugging difficult without access to the client. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MoonBoi9001
force-pushed
the
feat/dips-rejection-logging
branch
from
d67f78c to
a327c46
Compare
Contributor
Coverage Report for CI Build 25478599586Warning No base build found for commit Coverage: 71.42%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
MoonBoi9001
changed the title
Member
Author
|
Superseded by #1032 — work bundled into a single DIPs observability PR. The commits from this branch are cherry-picked into mb9/dips-observability-improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
When the indexer rejects a paid indexing proposal, today nothing about why is recorded on the indexer side — only the consumer sees the reason. This change writes the rejection reason and proposed deployment ID to the indexer's logs at info level. The change is logging-only, with no behaviour or wire format changes.
Motivation
When a payer submits a paid indexing agreement proposal to the indexer, the indexer's service responds over its proposal API with a reject reason but writes nothing to its own logs. An operator looking at the indexer's logs alone can see that proposals are flowing in and being rejected, but cannot tell which subgraph deployment was being proposed or why each one was turned down. Diagnosing a wave of rejections then requires correlating with the consumer side, which an indexer operator may not have access to.
Summary