feat(dips): add chain_id and structured fields to price rejection logs#990
Open
MoonBoi9001 wants to merge 2 commits intomb9/dips-signer-validation-loggingfrom
Open
feat(dips): add chain_id and structured fields to price rejection logs#990MoonBoi9001 wants to merge 2 commits intomb9/dips-signer-validation-loggingfrom
MoonBoi9001 wants to merge 2 commits intomb9/dips-signer-validation-loggingfrom
Conversation
MoonBoi9001
changed the base branch from
mb9/dips-startup-config-logging
to
mb9/dips-signer-validation-logging
Price rejection logs now include chain_id (CAIP-2 identifier) and use structured tracing fields (offered, minimum) instead of format string interpolation. Makes it easier to filter and query rejection events in production log aggregation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
MoonBoi9001
force-pushed
the
mb9/dips-price-rejection-logging
branch
from
6de8e3e to
a7671d3
Compare
Pins the expected bytes16 output for a fixed set of RCA inputs. The same test vector exists in dipper (dipper-rpc/src/indexer.rs). If either repo's derivation drifts, the test fails with a message pointing to the counterpart. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
During local-network testing, price rejection logs showed the offered and minimum values in a format string but lacked chain context. When running with multiple networks, an operator can't filter rejections by chain without parsing the message text. The network name was present but the CAIP-2 chain identifier (e.g.,
eip155:42161for Arbitrum One) was not, making it harder to correlate with on-chain data.Summary
additional_networksconfigchain_idin all price-related rejection logsoffered,minimum) for queryabilitytokens_per_secondandtokens_per_entity_per_secondrejection pathsGenerated with Claude Code