feat: Advanced breaking change detection for inputs and arguments for router #6906
+842
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jdolle
reviewed
Jul 30, 2025
| .insert(format!("{arg_type_name}.{value_str}").to_string()); | ||
| } | ||
| Value::List(_) => { | ||
| // handled by enter_list_value |
jdolle
reviewed
Aug 7, 2025
jdolle
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
This looks good to me.
The output matches what our js library produces.
@kamilkisiela could you please review the GoLang specifics?
jdolle
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Addressing: #6816
Whether an input field is used as nullable or non-nullable must be included within the reported schema coordinates using the ! character.
Description
To accurately determine whether a change is breaking or not based on traffic, we must track whether or not an argument or input's value has actually been provided or not.
Track used variables, if input variables were provided, non null variables, and variables with defaults.
Add unit tests based on #6816
Didn't E2E test - just added unit tests.
Also not sure how to check passed in variables if anyone could help with that.
Checklist