Skip to content

Conversation

@jdolle
Copy link
Collaborator

@jdolle jdolle commented Jan 6, 2026

Background

A piece of feedback on the proposals work was that the diff view feels very large.
This reduces the size and spacing of the text.

Screenshot 2026-01-06 at 11 57 30 AM

Description

Screenshot 2026-01-06 at 11 57 11 AM

@jdolle jdolle requested a review from n1ru4l January 6, 2026 19:59
@jdolle jdolle self-assigned this Jan 6, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jdolle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses user feedback regarding the large appearance of the proposal diff view. The changes aim to enhance readability and user experience by making the diff display more compact through adjustments to text size and cell spacing, without altering the core functionality of the diff comparison.

Highlights

  • Text Size Reduction: The text size within the proposal diff view has been reduced by applying the 'text-sm' utility class to the main table element, making the content more compact.
  • Spacing Adjustment: The padding around the line number cells in the diff view has been decreased by removing the 'p-1' utility class, which helps to reduce the overall visual spacing and make the diff feel less 'large'.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request modifies the styling of the schema diff components. It updates the ChangeDocument component by adding text-sm to the table's className, reducing the font size. Additionally, it removes the p-1 padding from the <td> elements within the ChangeRow component, which are responsible for displaying schema document row numbers. No review comments were provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7466.hive-storybook.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/apollo 0.46.0-alpha-20260106200126-58373a888e42cea49f573f78f415cd1f3cde138b npm ↗︎ unpkg ↗︎
@graphql-hive/cli 0.57.0-alpha-20260106200126-58373a888e42cea49f573f78f415cd1f3cde138b npm ↗︎ unpkg ↗︎
@graphql-hive/core 0.19.0-alpha-20260106200126-58373a888e42cea49f573f78f415cd1f3cde138b npm ↗︎ unpkg ↗︎
@graphql-hive/envelop 0.40.1-alpha-20260106200126-58373a888e42cea49f573f78f415cd1f3cde138b npm ↗︎ unpkg ↗︎
@graphql-hive/yoga 0.46.1-alpha-20260106200126-58373a888e42cea49f573f78f415cd1f3cde138b npm ↗︎ unpkg ↗︎
hive 8.14.0-alpha-20260106200126-58373a888e42cea49f573f78f415cd1f3cde138b npm ↗︎ unpkg ↗︎
hive-apollo-router-plugin 2.3.6-alpha-20260106200126-58373a888e42cea49f573f78f415cd1f3cde138b npm ↗︎ unpkg ↗︎
hive-console-sdk-rs 0.2.3-alpha-20260106200126-58373a888e42cea49f573f78f415cd1f3cde138b npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

💻 Website Preview

The latest changes are available as preview in: https://pr-7466.hive-landing-page.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 58373a888e42cea49f573f78f415cd1f3cde138b

@jdolle jdolle merged commit ccf4bf4 into main Jan 7, 2026
26 checks passed
@jdolle jdolle deleted the proposal-diff-size branch January 7, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants