fix: check for external on parent type #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ru4l
approved these changes
Aug 27, 2025
n1ru4l
approved these changes
Sep 15, 2025
n1ru4l
pushed a commit
that referenced
this pull request
Sep 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @theguild/[email protected] ### Patch Changes - [#185](#185) [`5e3cb1a`](5e3cb1a) Thanks [@jdolle](https://github.com/jdolle)! - tag extraction respects @external on parent - [#186](#186) [`2a1475f`](2a1475f) Thanks [@n1ru4l](https://github.com/n1ru4l)! - Fix failing satisfiability check for interface types. - [#167](#167) [`3e224c8`](3e224c8) Thanks [@jdolle](https://github.com/jdolle)! - Respect @external on parent type Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
@externalon types. According to the spec (https://www.apollographql.com/docs/graphos/schema-design/federated-schemas/reference/directives#external) if@externalis defined on the type, then all fields inside that type are considered external.