-
Notifications
You must be signed in to change notification settings - Fork 2
chore: release #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: release #476
Conversation
Summary of ChangesHello @theguild-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine release for two key components: Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, generated by release-plz
, correctly bumps the versions of hive-router-plan-executor
to 4.0.0
and hive-router
to 0.0.12
. The changes in Cargo.toml
, Cargo.lock
, and the changelogs are consistent with the release. I've added one suggestion to improve the changelog for hive-router-plan-executor
to make the breaking changes more explicit for consumers of the library.
### Added | ||
|
||
- *(executor)* normalize flatten errors for the final response ([#454](https://github.com/graphql-hive/router/pull/454)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since version 4.0.0 is a major release with breaking API changes, it's helpful to explicitly list them in the changelog. This provides better visibility for developers and helps prevent issues during upgrades. I'd suggest adding a Changed
section to highlight these breaking changes.
### Added | |
- *(executor)* normalize flatten errors for the final response ([#454](https://github.com/graphql-hive/router/pull/454)) | |
### Changed | |
- **BREAKING**: The function signatures for traverse_and_callback_mut and ExecutionContext::handle_errors have been updated. | |
### Added | |
- *(executor)* normalize flatten errors for the final response ([#454](https://github.com/graphql-hive/router/pull/454)) |
✅
|
🐋 This PR was built and pushed to the following Docker images: Image Names: Platforms: Image Tags: Docker metadata{
"buildx.build.ref": "builder-d5be6f8c-0f13-4d58-954f-1546334b4d58/builder-d5be6f8c-0f13-4d58-954f-1546334b4d580/ng9gc6uqu9fqjhi4oux6vvg1v",
"containerimage.descriptor": {
"mediaType": "application/vnd.oci.image.index.v1+json",
"digest": "sha256:3dc55a86d3bc7348009fd1711ad21db4cda2e769676595867d130a4eb7783289",
"size": 1609
},
"containerimage.digest": "sha256:3dc55a86d3bc7348009fd1711ad21db4cda2e769676595867d130a4eb7783289",
"image.name": "ghcr.io/graphql-hive/router:pr-476,ghcr.io/graphql-hive/router:sha-8edc51b"
} |
b6e9bc5
to
ab923be
Compare
🤖 New release
hive-router-plan-executor
: 3.0.0 -> 4.0.0 (⚠ API breaking changes)hive-router
: 0.0.11 -> 0.0.12 (✓ API compatible changes)⚠
hive-router-plan-executor
breaking changesChangelog
hive-router-plan-executor
hive-router
This PR was generated with release-plz.