Skip to content

Conversation

theguild-bot
Copy link
Collaborator

@theguild-bot theguild-bot commented Oct 9, 2025

🤖 New release

  • hive-router-plan-executor: 3.0.0 -> 4.0.0 (⚠ API breaking changes)
  • hive-router: 0.0.11 -> 0.0.12 (✓ API compatible changes)

hive-router-plan-executor breaking changes

--- failure function_parameter_count_changed: pub fn parameter count changed ---

Description:
A publicly-visible function now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/function_parameter_count_changed.ron

Failed in:
  hive_router_plan_executor::utils::traverse::traverse_and_callback_mut now takes 5 parameters instead of 4, in /tmp/.tmpqqS0NQ/router/lib/executor/src/utils/traverse.rs:9

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/method_parameter_count_changed.ron

Failed in:
  hive_router_plan_executor::context::ExecutionContext::handle_errors now takes 4 parameters instead of 2, in /tmp/.tmpqqS0NQ/router/lib/executor/src/context.rs:45
Changelog

hive-router-plan-executor

4.0.0 - 2025-10-09

Added

  • (executor) include subgraph name and code to the errors (#477)
  • (executor) normalize flatten errors for the final response (#454)

hive-router

0.0.12 - 2025-10-09

Added

  • (executor) include subgraph name and code to the errors (#477)
  • (executor) normalize flatten errors for the final response (#454)


This PR was generated with release-plz.

Copy link
Contributor

Summary of Changes

Hello @theguild-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine release for two key components: hive-router-plan-executor and hive-router. The hive-router-plan-executor module receives a major version bump due to necessary API breaking changes, primarily concerning function and method parameter counts. Concurrently, hive-router undergoes a minor version update. Both releases integrate an enhancement focused on standardizing the format of flattened errors in responses, aiming for more consistent error handling.

Highlights

  • Major Version Update for hive-router-plan-executor: The hive-router-plan-executor package has been updated from version 3.0.0 to 4.0.0, indicating significant API breaking changes.
  • Minor Version Update for hive-router: The hive-router package has been updated from version 0.0.11 to 0.0.12, which includes API compatible changes.
  • Breaking Changes Detailed: The breaking changes in hive-router-plan-executor specifically involve changes in parameter counts for the traverse_and_callback_mut function (from 4 to 5 parameters) and the ExecutionContext::handle_errors method (from 2 to 3 parameters).
  • Error Normalization Feature: Both updated packages now include functionality to 'normalize flatten errors for the final response', as referenced in PR feat(executor): normalize flatten errors for the final response #454.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, generated by release-plz, correctly bumps the versions of hive-router-plan-executor to 4.0.0 and hive-router to 0.0.12. The changes in Cargo.toml, Cargo.lock, and the changelogs are consistent with the release. I've added one suggestion to improve the changelog for hive-router-plan-executor to make the breaking changes more explicit for consumers of the library.

Comment on lines 12 to 15
### Added

- *(executor)* normalize flatten errors for the final response ([#454](https://github.com/graphql-hive/router/pull/454))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since version 4.0.0 is a major release with breaking API changes, it's helpful to explicitly list them in the changelog. This provides better visibility for developers and helps prevent issues during upgrades. I'd suggest adding a Changed section to highlight these breaking changes.

Suggested change
### Added
- *(executor)* normalize flatten errors for the final response ([#454](https://github.com/graphql-hive/router/pull/454))
### Changed
- **BREAKING**: The function signatures for traverse_and_callback_mut and ExecutionContext::handle_errors have been updated.
### Added
- *(executor)* normalize flatten errors for the final response ([#454](https://github.com/graphql-hive/router/pull/454))

Copy link

github-actions bot commented Oct 9, 2025

k6-benchmark results

     ✓ response code was 200
     ✓ no graphql errors
     ✓ valid response structure

     █ setup

     checks.........................: 100.00% ✓ 228627      ✗ 0    
     data_received..................: 6.7 GB  222 MB/s
     data_sent......................: 89 MB   3.0 MB/s
     http_req_blocked...............: avg=3.59µs   min=641ns   med=1.72µs  max=6.02ms   p(90)=2.49µs  p(95)=2.9µs   
     http_req_connecting............: avg=901ns    min=0s      med=0s      max=2.86ms   p(90)=0s      p(95)=0s      
     http_req_duration..............: avg=19.22ms  min=1.91ms  med=18.36ms max=159.99ms p(90)=26.3ms  p(95)=29.36ms 
       { expected_response:true }...: avg=19.22ms  min=1.91ms  med=18.36ms max=159.99ms p(90)=26.3ms  p(95)=29.36ms 
     http_req_failed................: 0.00%   ✓ 0           ✗ 76229
     http_req_receiving.............: avg=132.68µs min=25.86µs med=40.36µs max=32.57ms  p(90)=92.79µs p(95)=390.59µs
     http_req_sending...............: avg=24.14µs  min=5.37µs  med=10.53µs max=22.11ms  p(90)=16.34µs p(95)=28.27µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=19.06ms  min=1.86ms  med=18.24ms max=159.7ms  p(90)=26.05ms p(95)=29.04ms 
     http_reqs......................: 76229   2535.944887/s
     iteration_duration.............: avg=19.67ms  min=3.96ms  med=18.71ms max=255.34ms p(90)=26.77ms p(95)=29.9ms  
     iterations.....................: 76209   2535.279538/s
     vus............................: 50      min=50        max=50 
     vus_max........................: 50      min=50        max=50 

Copy link

github-actions bot commented Oct 9, 2025

🐋 This PR was built and pushed to the following Docker images:

Image Names: ghcr.io/graphql-hive/router

Platforms: linux/amd64,linux/arm64

Image Tags: ghcr.io/graphql-hive/router:pr-476 ghcr.io/graphql-hive/router:sha-8edc51b

Docker metadata
{
"buildx.build.ref": "builder-d5be6f8c-0f13-4d58-954f-1546334b4d58/builder-d5be6f8c-0f13-4d58-954f-1546334b4d580/ng9gc6uqu9fqjhi4oux6vvg1v",
"containerimage.descriptor": {
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "digest": "sha256:3dc55a86d3bc7348009fd1711ad21db4cda2e769676595867d130a4eb7783289",
  "size": 1609
},
"containerimage.digest": "sha256:3dc55a86d3bc7348009fd1711ad21db4cda2e769676595867d130a4eb7783289",
"image.name": "ghcr.io/graphql-hive/router:pr-476,ghcr.io/graphql-hive/router:sha-8edc51b"
}

@theguild-bot theguild-bot force-pushed the release-plz-2025-10-09T12-46-08Z branch from b6e9bc5 to ab923be Compare October 9, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant