Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added description to relationships #200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sedough
Copy link

@sedough sedough commented Apr 2, 2019

Generates a description for a SQLAlchemy relationship field using the "doc" attribute.

@coveralls
Copy link

coveralls commented Apr 2, 2019

Coverage Status

Coverage increased (+0.02%) to 91.922% when pulling 8168aaa on sedough:relationship-doc into c9af40c on graphql-python:master.

Copy link
Collaborator

@jnak jnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Seems like a good idea. Would you mind adding simple tests for that?

@@ -35,7 +35,7 @@ def dynamic_type():
elif direction in (interfaces.ONETOMANY, interfaces.MANYTOMANY):
if _type._meta.connection:
return createConnectionField(_type._meta.connection)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like createConnectionField could benefit from this as well

@MrEbbinghaus
Copy link

@jnak Any progress on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants