Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Graphene v3 #296

Closed
wants to merge 6 commits into from

Conversation

DoctorJohn
Copy link
Contributor

A while ago I started working on #248 in an afford to port all remaining graphene integrations to graphene v3. Unfortunately I never completely finished this port. Hope the community will benefit from my initial work and jump in to resolve the remaining issues.

Currently 8 out of 117 tests are still failing:

graphene_sqlalchemy/tests/test_batching.py FFFF.F.                                     [  5%]
graphene_sqlalchemy/tests/test_benchmark.py ..FF                                       [  8%]
graphene_sqlalchemy/tests/test_converter.py ........................................   [ 40%]
graphene_sqlalchemy/tests/test_enums.py .......                                        [ 46%]
graphene_sqlalchemy/tests/test_fields.py .........                                     [ 53%]
graphene_sqlalchemy/tests/test_query.py .....                                          [ 57%]
graphene_sqlalchemy/tests/test_query_enums.py ....                                     [ 60%]
graphene_sqlalchemy/tests/test_reflected.py .                                          [ 61%]
graphene_sqlalchemy/tests/test_registry.py ........                                    [ 68%]
graphene_sqlalchemy/tests/test_sort_enums.py ...........F                              [ 77%]
graphene_sqlalchemy/tests/test_types.py ...................                            [ 92%]
graphene_sqlalchemy/tests/test_utils.py .........                                      [100%]

I haven't touched the batchings tests yet since I noticed batching makes use of the promise library and dataloaders, which graphene dropped support for (AFAIK). It needs to be decided whether this integration will drop support for it as well.

The benchmarking tests fail due to null being returned for some not nullable fields. Needs investigation.

The sort_enums test yields Can't resolve label reference for ORDER BY / GROUP BY / DISTINCT etc. Textual SQL expression 'NAME_ASC'...d be explicitly declared as text('NAME_ASC'). I had a hard time debugging since I'm unfamiliar with SqlAlchemy and thus didn't really know what to look out for.

@zsiciarz zsiciarz mentioned this pull request May 4, 2021
@DoctorJohn
Copy link
Contributor Author

Closing this in favor of #317 which is based on #306 which is based on this PR.

@DoctorJohn DoctorJohn closed this Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant