Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago I started working on #248 in an afford to port all remaining graphene integrations to graphene v3. Unfortunately I never completely finished this port. Hope the community will benefit from my initial work and jump in to resolve the remaining issues.
Currently 8 out of 117 tests are still failing:
I haven't touched the batchings tests yet since I noticed batching makes use of the promise library and dataloaders, which graphene dropped support for (AFAIK). It needs to be decided whether this integration will drop support for it as well.
The benchmarking tests fail due to null being returned for some not nullable fields. Needs investigation.
The sort_enums test yields
Can't resolve label reference for ORDER BY / GROUP BY / DISTINCT etc. Textual SQL expression 'NAME_ASC'...d be explicitly declared as text('NAME_ASC')
. I had a hard time debugging since I'm unfamiliar with SqlAlchemy and thus didn't really know what to look out for.