Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum value equality comparison #1525

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cc-jj
Copy link

@cc-jj cc-jj commented Sep 1, 2023

Fix for #1524

This change takes care to preserve the current behavior where different enums with identical values are non-equal.

However it fixes inconsistent behavior when comparing enums to non-enum values. These comparisons would sometimes identify the non-enum values as equal and other times as non-equal due to is comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants