-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to poetry #1565
Open
dulmandakh
wants to merge
16
commits into
graphql-python:master
Choose a base branch
from
dulmandakh:pyproject
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
migrate to poetry #1565
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c113332
pyproject.toml
dulmandakh 1180c5e
fix deploy
dulmandakh 73c43b0
Merge branch 'master' into pyproject
dulmandakh c92260b
ddd
dulmandakh 4238a3f
poetry lock
dulmandakh e381718
install poetry
dulmandakh 68a5fd0
pipx
dulmandakh 75fa9f5
sss
dulmandakh 4f35691
sss
dulmandakh ef7e7a1
ddd
dulmandakh c08c3c1
sss
dulmandakh 03c634e
coverage
dulmandakh c1181c7
remove version
dulmandakh f6dbc2f
skip_install = true
dulmandakh ecc2599
poetry install --sync
dulmandakh b3e4e64
remove __version__ export
dulmandakh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's important to keep
__version__, as certain extension libraries use it do distignuish between different grapehene releases. I'm fine with deprecation, as python 3.8'simportlib.metadata.version('graphene')is a viable alternative. I'd suggest usingimportlibto fill__version__and deprecating it, recommending direct use of importlib instead. What do you think? 😊There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into it and make changes accordingly