Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CONTRIBUTING.md #56

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Create CONTRIBUTING.md #56

wants to merge 7 commits into from

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Oct 31, 2024

Make a simple file to add things we are following when writing the spec

Make a simple file to add things we are following when writing the spec
CONTRIBUTING.md Outdated Show resolved Hide resolved
@smyrick
Copy link
Contributor Author

smyrick commented Nov 7, 2024

  • Mention working WG
  • Link out to YouTube
  • Slim README

@smyrick
Copy link
Contributor Author

smyrick commented Nov 7, 2024

I cloned the repo locally to run npm run format which is why there is the changes to lock files.

I also assumed that we should use npm and not yarn since that was the original lock file and so I cleaned that up for anyone else and specified that in the CONTRIBUTING file

@smyrick smyrick requested a review from benjie January 22, 2025 22:59
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for composite-schemas ready!

Name Link
🔨 Latest commit 195fa75
🔍 Latest deploy log https://app.netlify.com/sites/composite-schemas/deploys/67929941fba5ea00087ef92b
😎 Deploy Preview https://deploy-preview-56--composite-schemas.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benjie
Copy link
Member

benjie commented Jan 23, 2025

Perhaps you might want to recommend this stylistic approach as well? #130 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants