Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update monorepo packages to TypeScript v5 #3237

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dimaMachina
Copy link
Collaborator

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2023

🦋 Changeset detected

Latest commit: f3b2225

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
cm6-graphql Patch
codemirror-graphql Patch
graphiql Patch
@graphiql/plugin-code-exporter Patch
@graphiql/plugin-explorer Patch
@graphiql/react Patch
@graphiql/toolkit Patch
graphql-language-service Patch
graphql-language-service-cli Patch
monaco-graphql Patch
graphql-language-service-server Patch
vscode-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -33,7 +33,7 @@ CodeMirror.defineOption(
},
);

function createState(options: GraphQLInfoOptions) {
function createState(options: GraphQLInfoOptions | true | (() => any)) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also added the missing type for function while checking options instanceof Function

Comment on lines -343 to +347
json: string | undefined;
json?: string;
errorMessageParse: string;
errorMessageType: string;
}) {
let parsed: Record<string, any> | undefined;
let parsed: Record<string, unknown> | undefined;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Comment on lines +172 to 173
// @ts-expect-error don't know how to fix 'yield' expression implicitly results in an 'any' type because its containing generator lacks a return-type annotation.
return yield response.json();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@n1ru4l I lack knowledges how to better fix it 😢

Comment on lines -115 to +113
severity: 5,
// severity: toMonacoSeverity(diagnostic.severity),
severity: monaco.MarkerSeverity.Error,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@acao I'm not sure if I'm right

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is correct. it should be monaco.MarkerSeverity.Error, not sure how it regressed

@acao
Copy link
Member

acao commented Jun 17, 2023

looks like typedoc upgrade needs to happen first, but if we don't mind breaking typedoc temporarily to move forward with alpha, that is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants