-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update monorepo packages to TypeScript v5 #3237
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: f3b2225 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -33,7 +33,7 @@ CodeMirror.defineOption( | |||
}, | |||
); | |||
|
|||
function createState(options: GraphQLInfoOptions) { | |||
function createState(options: GraphQLInfoOptions | true | (() => any)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also added the missing type for function while checking options instanceof Function
json: string | undefined; | ||
json?: string; | ||
errorMessageParse: string; | ||
errorMessageType: string; | ||
}) { | ||
let parsed: Record<string, any> | undefined; | ||
let parsed: Record<string, unknown> | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// @ts-expect-error don't know how to fix 'yield' expression implicitly results in an 'any' type because its containing generator lacks a return-type annotation. | ||
return yield response.json(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@n1ru4l I lack knowledges how to better fix it 😢
severity: 5, | ||
// severity: toMonacoSeverity(diagnostic.severity), | ||
severity: monaco.MarkerSeverity.Error, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

@acao I'm not sure if I'm right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is correct. it should be monaco.MarkerSeverity.Error
, not sure how it regressed
looks like typedoc upgrade needs to happen first, but if we don't mind breaking typedoc temporarily to move forward with alpha, that is fine |
No description provided.