-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pnpm + turbo (no cjs + no ts project refs) #3306
base: main
Are you sure you want to change the base?
Conversation
|
4fd5433
to
7d8967a
Compare
982e740
to
d6f7a71
Compare
The latest changes of this PR are not available as canary, since there are no linked |
@B2o5T please note that when a PR is in draft state, it is not ready to review. I appreciate the early review, but things are subject to change drastically. This is everything that is needed to move to Other preliminary work has already happened - webpack upgrade, etc. All of these changes are a consequence of migrating to For changes that can happen in smaller PRs, I plan to seperate them out, thus why this PR is a draft. Please, to save you time, don't review until it is is out of draft state, ok? |
1d9eea6
to
ce46877
Compare
yay! cypress now runs using something closer to the reccomended config. we had to move cypress back into root |
@B2o5T I will include instructions soon on how to try this out and start giving very specifically scoped feedback and/or contribution if you are interested. It has somehow introduced a few detectable regressions, see notes. The vscode extension tests will take precedence as they are of a greater concern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
this one is for real, not just for reference!
build
anddev
packages to every workspacebuild-bundles
exports
for codemirror-graphqlcodemirror-graphql
jsonParser exceptions to not be caught as linter errors??Notes
pnpm dev
alongsidecypress open
orjest
, a common workflow for me when working across packages, seems to crash my PC@graphiql/react
tsconfig.json was configured to compile__test__
directory. this was not needed forjest-ts
but seemed to make eslint happy, but i found a way to resolve thisWhat can hopefully come in later PRs:
it's a more lean version of #3303 with some agreed upon tooling changes