make monaco-graphql true esm with "type": "module" and "exports" field, simplify it's exports
#3327
Conversation
|
| Name | Type |
|---|---|
| codemirror-graphql | Major |
| graphql-language-service | Major |
| graphql-language-service-cli | Major |
| graphql-language-service-server | Major |
| monaco-graphql | Major |
| cm6-graphql | Minor |
| @graphiql/react | Minor |
| @graphiql/toolkit | Minor |
| graphiql | Patch |
| vscode-graphql | Patch |
| @graphiql/plugin-explorer | Major |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
| "scripts": { | ||
| "build": "cross-env NODE_ENV=production webpack-cli", | ||
| "start": "cross-env NODE_ENV=development webpack-cli serve" | ||
| "bundle": "cross-env NODE_ENV=production webpack-cli", |
There was a problem hiding this comment.
renamed to bundle because build from root fails since I added this example to workspace and postbuild are executed too late for this example (should be fixed after setup of turbo)
|
The latest changes of this PR are not available as canary, since there are no linked |
| self.onmessage = () => { | ||
| globalThis.onmessage = () => { |
There was a problem hiding this comment.
monaco-editor uses globalThis in latest version instead of self
| @@ -21,17 +44,14 @@ | |||
| "directory": "packages/monaco-graphql" | |||
| }, | |||
| "files": [ | |||
| "dist", | |||
| "src", | |||
There was a problem hiding this comment.
I know I already wrote it but let's stop publish src dir
| "monaco-editor": ">= 0.20.0 < 1", | ||
| "monaco-editor": ">= 0.39.0 < 1", |
There was a problem hiding this comment.
update as per Rikki suggestion for next major
There was a problem hiding this comment.
is there a reason we need 0.39.0 specifically? is there a more forgiving range we can support? we should document what we use from the 0.39.0 release that deprecates support for 0.38.0 etc
There was a problem hiding this comment.
No reason, which version you propose to bump?
There was a problem hiding this comment.
@acao I was rethinking this, since in monaco-editor every minor version is major, according to semver policy (since major is 0) let's bump it as highest as possible (0.40.0 in this case)
|
@acao something was broken with your latest updates, |
|
@B2o5T yes, there is a race condition where the graphiql build begins before the |
|
@B2o5T try rebasing again, it should work better now |
| @@ -9,7 +9,16 @@ | |||
| '@graphiql/toolkit': minor | |||
| --- | |||
|
|
|||
| _BREAKING CHANGE:_ drop commonjs exports in all libraries except for `graphiql` and `@graphiql/react` | |||
| _BREAKING CHANGE:_ drop commonjs exports in all libraries except for `graphiql` | |||
| and `@graphiql/react` | |||
There was a problem hiding this comment.
why is this on a new line? it's harder to read
There was a problem hiding this comment.
Some locale prettier changes, will revert 👍
acao
changed the title
monaco-graphql true esm with "type": "module" and "exports" field, simplify his exportsmonaco-graphql true esm with "type": "module" and "exports" field, simplify it's exports
No description provided.