demo: monaco type links for hover #3387
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8719cd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
acao
commented
Aug 2, 2023
| if (options.typeLinks && options.useMarkdown) { | ||
| text( | ||
| into, | ||
| `\n\`\`\`](command:DYNAMIC_1?${encodeURIComponent( |
There was a problem hiding this comment.
@jonathanawesome where the magic happens 😆
✅ Deploy Preview for graphiql-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3387 +/- ##
==========================================
+ Coverage 55.76% 55.77% +0.01%
==========================================
Files 110 110
Lines 5242 5266 +24
Branches 1425 1437 +12
==========================================
+ Hits 2923 2937 +14
- Misses 1896 1902 +6
- Partials 423 427 +4
|
|
The latest changes of this PR are not available as canary, since there are no linked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an example of how to pass type information when clicking a type in a hover
currently we cannot figure out how to get it to work without causing a regression in the hover, where the code block styling is reverted to a simple non-tokenized code block, in order to get the
<a href="commandto workthe only mystery is how to get this working and preserve syntax highlighting for hover types!
TODO:
monaco-graphqlso we can pass the command ID to thegraphql-language-servicedynamically