Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrate React Context to Zustand #3757

Draft
wants to merge 16 commits into
base: graphiql-v4
Choose a base branch
from
Draft

[WIP] Migrate React Context to Zustand #3757

wants to merge 16 commits into from

Conversation

acao
Copy link
Member

@acao acao commented Aug 30, 2024

so excited for this long awaited PR, thank you @dimaMachina for providing the impetus and this big rework to build off of!

Summary

  • converts @graphiql/react react contexts to use zustand with immer
  • moves most of this logic to @graphiql/toolkit where the new store is located
  • most contexts in @graphiql/react will be deleted, except for maybe plugin context and theme context

Checklist

  • editor context & hooks
  • schema context & hooks
  • execution context & hooks
  • graphiql working (base case)
  • refactor zustand & @graphiql/react
  • explorer context & hooks
  • history context & hooks
  • fix/migrate existing test coverage
  • add new test coverage where useful
  • graphiql working (fully)
  • e2e passing

Copy link

changeset-bot bot commented Aug 30, 2024

⚠️ No Changeset found

Latest commit: b213ceb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@acao acao requested a review from dimaMachina August 30, 2024 11:24
@acao acao added the graphiql label Aug 30, 2024
@acao acao added this to the [email protected] milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant