Open
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @robrichard , do you have any expected timeline for this feature? We are really excited to have this feature for our product! |
benjie
added
💭 Strawman (RFC 0)
mostly to reduce the diff.
instead of sometimes fieldGroup, for consistency and so as to remove another "Group" term
accompanying note is a WIP, open to further suggestions as to how to clarify
…ting an Execution Plan" section
… root nodes before the graph was adjusted
* Add Response Section for defer/stream * review fixes * fix
* Add defer and stream directives to type system * Add defer/stream validation rules
robrichard
force-pushed
the
robrichard/defer-stream-v2
branch
from
9ec7f65 to
f7e9124
Compare
yaacovCR
reviewed
Jan 9, 2025
Member
|
The previous spec edits reached RFC2, should this also be RFC2? |
BoD
reviewed
Jul 17, 2025
| "incremental": [ | ||
| { | ||
| "id": "1", | ||
| "data": { "lastName": "Skywalker" }] |
Contributor
There was a problem hiding this comment.
Suggested change
| "data": { "lastName": "Skywalker" }] | |
| "data": { "lastName": "Skywalker" } |
michaelstaib
reviewed
Feb 2, 2026
|
|
||
| - If {serial} is not provided, initialize it to {false}. | ||
| - Let {groupedFieldSet} and {newDeferUsages} be the result of | ||
| {CollectFields(objectType, selectionSet, variableValues)}. |
Member
There was a problem hiding this comment.
The new CollectFields requires a deferUsage argument ... this should be null for the initial call to CollectFields.
Suggested change
| {CollectFields(objectType, selectionSet, variableValues)}. | |
| {CollectFields(objectType, selectionSet, null, variableValues)}. |
Also in this case its not clear while reading what null actually is for so maybe it should be declared first?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec draft of
@deferbased on the response format in graphql/defer-stream-wg#69, with no duplication of fields.@streamwill be added soon.Please keep discussion limited to specifics on how the spec text is written. There is a dedicated discussion forum for questions, feedback, and comments on defer & stream: https://github.com/graphql/defer-stream-wg/discussions