Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation and spec simplicity #1656

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Add implementation and spec simplicity #1656

merged 1 commit into from
Feb 17, 2025

Conversation

twof
Copy link
Contributor

@twof twof commented Feb 17, 2025

This has come up as a decision point in discord a few times. In my opinion, the proposal (and GQL generally) should operate in service of the end user, and we should do what's necessary to fulfill user needs. If the spec or the implementation cannot fulfill user needs, then changes should be made so that they can.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that if you ignore document directives which are an external concern, (3) is also pretty simple both to specify and to implement. That said, the fact it requires document directives in itself makes it complex, so I'm inclined to agree 👍

@benjie benjie merged commit 2a09600 into graphql:main Feb 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants