Skip to content

Clarify C relates to nullability of unadorned type #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Clarify C relates to nullability of unadorned type #1659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
agendas/*/*.md
agendas/*/*/*.md
rfcs/SemanticNullability.md
8 changes: 4 additions & 4 deletions rfcs/SemanticNullability.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,11 +242,11 @@ same meaning as they always did.

Criteria score: 🥇

## 🎯 C. Existing meanings should be retained
## 🎯 C. Unadorned type should mean nullable

GraphQL has been public for 10 years and there's a lot of content out there
noting that GraphQL types are nullable by default (unadorned type is nullable)
and that `!` means non-nullable. Our changes should not invalidate this content.
and our changes should not invalidate this content.

| [1][solution-1] | [2][solution-2] | [3][solution-3] | [4][solution-4] | [5][solution-5] |
|-----------------|-----------------|-----------------|-----------------|-----------------|
Expand Down Expand Up @@ -488,7 +488,7 @@ day-to-day work.
- [B][criteria-b]
- ✅ Executable documents are not impacted by this proposal.
- [C][criteria-c]
- ✅ `Int` means nullable, and `Int!` means non-nullable, still.
- ✅ `Int` means nullable still.
- [D][criteria-d]
- ✅ `Int!` to indicate non-nullable is common in programming languages; and
`Int!!` looks like it indicates "danger".
Expand Down Expand Up @@ -560,7 +560,7 @@ This proposal relies on the ability of clients to opt out of error propagation;
- [B][criteria-b]
- ✅ The change from nullable to non-nullable on output is backwards compatible from a type perspective; for impact on error boundaries see G.
- [C][criteria-c]
- ✅ `Int` means nullable, and `Int!` means non-nullable, still.
- ✅ `Int` means nullable still.
- [D][criteria-d]
- ⚠️ Adding `@onError` to operations is not immediately intuitive but most error-handling clients should add it automatically, making it transparent to end users.
- [E][criteria-e]
Expand Down