Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemanticNullability -> SemanticNullabilityType; add precision #1661

Closed
wants to merge 2 commits into from

Conversation

benjie
Copy link
Member

@benjie benjie commented Feb 18, 2025

Following discussion with @martinbonnin it became obvious that the title of this RFC was too broad and seemed to make it such that any proposal to disable null bubbling would solve the problem; however as outlined in the problem history the intent of this RFC is that schemas gain a new type to enable splitting the existing "nullable" into "semantically nullable" and "semantically non-nullable". I've renamed the RFC to include the word "type" and have added precision to the problem statement so that it better outlines the problem it is attempting to solve and is a better summary of the problem history section above it.

With this change, I think we should explicitly indicate that solution 5 is a counter-proposal - it's an argument against the need for a new explicit semantic nullability type.

cc @martinbonnin @twof

@benjie
Copy link
Member Author

benjie commented Feb 20, 2025

Closing as I'm inclined to agree with Martin that "semantic nullability" is the problem we're trying to solve for, and solution 5 - namely: use strictly-non-null to represent semantic-non-null - is a solution to that.

@benjie benjie closed this Feb 20, 2025
@martinbonnin
Copy link
Contributor

martinbonnin commented Feb 20, 2025

Link to the Discord discussion for future reference:

I think the original focus on "semantic nullability" was the good one actually. 
This is the problem we want to solve. Whether we do it with new types or GraphQL 2.0 
depends where we want to put the tradeoff but focusing on type system feels like 
narrowing the scope of possible solutions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants