Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add objection: lower the score of The solution should add value even with error propagation enabled #1667

Closed
wants to merge 1 commit into from

Conversation

martinbonnin
Copy link
Contributor

Feels like this is outside the "semantic nullability" problem.

The problem of indicating whether or not a position can error in the schema is a separate, larger problem IMO that could require larger changes like adding even more types to the type system:

String
Option<String>
Result<String, Error>
Result<Option<String>, Error> 

This is a much wider question though and I suggest we leave it out for now.

@benjie
Copy link
Member

benjie commented Feb 21, 2025

I personally thought it should be lower importance too, but @captbaritone convinced me otherwise at GraphQLConf, though I'll admit I don't remember his argument!

@benjie
Copy link
Member

benjie commented Mar 6, 2025

The score was lowered in #1686

@benjie benjie closed this Mar 6, 2025
@martinbonnin martinbonnin deleted the martinbonnin-patch-1 branch March 6, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants