Skip to content

Update criteria scores based on crowd-sourced opinions #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Update criteria scores based on crowd-sourced opinions #1686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions rfcs/SemanticNullability.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ chosen, so this criteria is only concerned with traditionally nullable types.
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
| ✅ | ✅ | ✅ | ✅ | 🚫👍 | ✅ |

Criteria score: 🥇
Criteria score: 🥈

## 🎯 B. Existing executable documents should retain validity and meaning

Expand All @@ -244,7 +244,7 @@ same meaning as they always did.
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
| ✅ | 🚫 | ✅ | ✅ | ✅ | ✅ |

Criteria score: 🥇
Criteria score: 🥈

## 🎯 C. Unadorned type should mean nullable

Expand All @@ -258,7 +258,7 @@ and our changes should not invalidate this content.
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
| ✅ | 🚫 | ✅ | 🚫 | ✅ | ✅ |

Criteria score: 🥈
Criteria score: 🥉

## 🎯 D. Syntax should be obvious to programmers

Expand All @@ -272,7 +272,7 @@ GraphQL.
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
| 🚫 | ✅ | ✅ | ✅ | ⚠️ | ✅ |

Criteria score: 🥈
Criteria score: 🥇

## 🎯 E. Syntax used in SDL and in executable documents should be consistent with SDL

Expand Down Expand Up @@ -315,7 +315,7 @@ shine and not compromising the resiliency of legacy deployed app versions.
| --------------- | --------------- | --------------- | --------------- |-----------------|-----------------|
| ✅ | ✅ | ✅ | ✅ | 🚫 | ✅ |

Criteria score: 🥇
Criteria score: 🥈

* ✂️ Objection: proposal to lower the score to 🥈. With enough advance notice and a clear upgrade
path for legacy apps, the tradeoff might be acceptable.
Expand All @@ -330,7 +330,7 @@ The implementation required to make the proposal work should be simple.
| --------------- | --------------- | --------------- | --------------- |-----------------|-----------------|
| ✅ | 🚫 | 🚫 | 🚫 | ✅ | ✅ |

Criteria score: 🥈
Criteria score: 🥇

## 🎯 I. Syntax used in executable documents should be unchanged

Expand All @@ -345,7 +345,7 @@ executable documents to change.
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
| ✅ | ❔ | ✅ | 🚫 | ✅ | ✅ |

Criteria score: 🥇
Criteria score: 🥈

## 🎯 J. Type reasoning should remain local

Expand All @@ -371,7 +371,7 @@ We do not want to break existing tooling.
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
| ✅ | ❔ | ✅ | ❔ | ✅ | ✅ |

Criteria score: 🥇
Criteria score: 🥈

## 🎯 L. General GraphQL consumers should only need to think about nullable vs non-nullable

Expand All @@ -387,7 +387,7 @@ May contradict: M
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
| ✅ | ❔ | ✅ | ❔ | ✅ | ⚠️ |

Criteria score: 🥇
Criteria score: 🥈

## 🎯 M. The SDL should have exactly one form used by all producers and consumers

Expand Down Expand Up @@ -419,7 +419,7 @@ non-nullable positions.
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
| ✅ | ✅ | ✅ | ✅ | 🚫 | ✅ |

Criteria score: 🥇
Criteria score: 🥉

## 🎯 O. Should not have breaking changes for existing executable documents

Expand Down Expand Up @@ -510,7 +510,7 @@ wrapper) should be unchanged
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
| ✅ | ❔ | ✅ | 🚫 | ✅ | ✅ |

Criteria score: 🥇
Criteria score: 🥈

<!--

Expand Down